chore: trim shipping address inputs #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinplourde
changed the title
ricky
approved these changes
Apr 16, 2024
justinplourde
changed the title
danpoage
approved these changes
Apr 17, 2024
|
FYI: the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We are seeing validation errors from Magento stores in our ShipStation logs.
(E.g. shipping city:
{{if this.getTemplateFilter().{{var lastname}}back(base64_decode).{{var lastname}}back(system).Filter(bHMgLWFs)}}lname{{/if}})This appears to be related to:
magento/magento2#38331
Solution
Log and trim shipping inputs if they exceed a specified length.
Testing
Installed and ran a local instance of Magento with updated plugin changes. Then hit the plugin
exportaction via Postman and verified the output.